Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): fix highlight of selected blindness color filter #9179

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

gaetanmaisse
Copy link
Member

What I did

Fix highlight of selected blindness color filter.

How to test

  • Open a story
  • Select a blindness color filter
  • Open the menu of blindness color filters
  • The previously selected filter should be highlighted

After the fix:
Dec-18-2019 08-11-53

@vercel
Copy link

vercel bot commented Dec 18, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/olxo5ynyf
🌍 Preview: https://monorepo-git-fix-a11y-active-highlight.storybook.now.sh

@gaetanmaisse
Copy link
Member Author

@shilman I think this fix should to included to 5.3 RC ;)

@gaetanmaisse
Copy link
Member Author

It looks like Puppeteer & A11y tests are also 🔴 on next 🤔

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit a19f606 into next Dec 18, 2019
@shilman shilman deleted the fix-a11y-active-highlight branch December 18, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants